Kf 3996 istio-pilot control plane configurable images with set #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#320 Summary of changes: - Modified code to use --set to alter precompile istioctl manifests to allow changes according to charm configuration.
i-chvets
changed the title
added 2 commits
August 30, 2023 15:57
#322 Summary of changes: - Added unit tests. - Modified config.yaml to make it consistent. - Added get config helper to allow for better testing. This can also be expanded further.
…github.com:canonical/istio-operators into KF-3996-control-plane-configurable-images-with-set
orfeas-k
reviewed
Aug 31, 2023
Summary of changes: - Modified code to only retrieve image configuration.
orfeas-k
approved these changes
Aug 31, 2023
i-chvets
deleted the
KF-3996-control-plane-configurable-images-with-set
branch
i-chvets
added a commit
that referenced
this pull request
Sep 25, 2023
# Description More details in: #322 The changes in this PR are based on work done in #316 Created a new PR to simplify workflow. # Summary of changes: - Modified code to use --set to alter precompile istioctl manifests to allow changes according to charm configuration. - Added `image-configuration` option to istio-pilot `config.yaml` - Added `proxy-image` option to istio-gatewat `config.yaml` - Added unit test for testing helper that retrieves configuration. # Testing For complete testing refer to #322 Related PR: #320 NOTE: Created [issue](#324) to track updates to process of updating Istio.
i-chvets
added a commit
that referenced
this pull request
Sep 25, 2023
# Description More details in: #322 The changes in this PR are based on work done in #316 Created a new PR to simplify workflow. # Summary of changes: - Modified code to use --set to alter precompile istioctl manifests to allow changes according to charm configuration. - Added `image-configuration` option to istio-pilot `config.yaml` - Added `proxy-image` option to istio-gatewat `config.yaml` - Added unit test for testing helper that retrieves configuration. # Testing For complete testing refer to #322 Related PR: #320 NOTE: Created [issue](#324) to track updates to process of updating Istio.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More details in: #322
The changes in this PR are based on work done in #316
Created a new PR to simplify workflow.
Summary of changes:
image-configurationoption to istio-pilotconfig.yamlproxy-imageoption to istio-gatewatconfig.yamlTesting
For complete testing refer to #322
Related PR: #320
NOTE: Created issue to track updates to process of updating Istio.